feat: modify workflow actions to remove icu-config-removal - #635
Open
Rolaxgar97 wants to merge 8 commits into
Open
feat: modify workflow actions to remove icu-config-removal#635Rolaxgar97 wants to merge 8 commits into
Rolaxgar97 wants to merge 8 commits into
Conversation
Rolaxgar97
changed the title
pkgdata requires the -O option pointing to pkgdata.inc for static builds. Previously this was supplied by an icu-config shim in the build container. Replace the implicit icu-config lookup with an explicit -O argument using pkg-config to resolve the ICU library directory: pkg-config --variable=pkglibdir icu-uc This removes the icu-config dependency entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request includes following changes or fixes.
Description
Changes to update the GitHub Actions workflow to remove the deprecated
icu-configscript from the workflow configuration.Fixes #issue_no
Type of change
Please delete items that are not relevant.
Checklist: